Remove underscore prefix from Validation class - property#325
Merged
LordSimal merged 1 commit intocakephp:6.xfrom Oct 5, 2025
Merged
Remove underscore prefix from Validation class - property#325LordSimal merged 1 commit intocakephp:6.xfrom
LordSimal merged 1 commit intocakephp:6.xfrom
Conversation
ADmad
reviewed
Aug 27, 2025
|
|
||
| $rectorConfig->ruleWithConfiguration(RenamePropertyRector::class, [ | ||
| new RenameProperty('Cake\ORM\Entity', '_accessible', 'patchable'), | ||
| new RenameProperty('Cake\Utility\Inflector', '_plural', 'plural'), |
Member
There was a problem hiding this comment.
We should only add rules for properties/classes which are likely to be overridden in user code, otherwise we will unnecessarily slow down the upgrade process by adding too many rules.
The likely hood of any of the classes in the PR to be overridden is very low.
Contributor
There was a problem hiding this comment.
I am fine with that, even though we don't really know what is more or less likels to be overwritten.
Member
There was a problem hiding this comment.
Admittedly, I am not sure how much slow down would be there if we added rules for all the properties/methods we are changing. So perhaps we can add them all for now, since they are usually one liners, and remove later if needed.
LordSimal
force-pushed
the
6.x_underscore_rector
branch
from
e3c28df to
89c9b90
Compare
LordSimal
pushed a commit
that referenced
this pull request
Jan 6, 2026
Co-authored-by: Arshid <arshid@Arshids-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.